Advective-then-Flux form for Runge-Kutta schemes #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommbendall
added
enhancement
atb1995
requested changes
Oct 28, 2024
There was a problem hiding this comment.
These changes largely look good to me, the use of the enumerated type is sensible and the changes successfully implement an advective-then-flux version of conservative transport. I'm happy that the change has sufficient testing, I only have a few minor comments/requests.
tommbendall
commented
Oct 28, 2024
Co-authored-by: Alex Brown <[email protected]>
atb1995
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an "advective-then-flux" form for RK schemes with the conservative transport equation.
This involves:
linear,predictorandincrementforms, which follow the attached documentlinearform, which allows the final RK stage of the final subcycle to use a different operatorall_but_lastlabel, which indicates the form to use for all but the very final RK stageadvective_then_fluxboolean argument to theDGUpwindoperator, which signifies to use theadvectiveform of the transport equation for all-but-the-last RK stageThis seems to have a similarly positive impact to the density/depth predictor for transport with large Courant numbers.